-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json #20826
[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json #20826
Conversation
fba67c0
to
b26025d
Compare
@judyjoseph Please review this asic-sensors PR. Thanks |
7c56970
to
f991ffc
Compare
@arlakshm This Includes the Yang Model for ASIC_SENSORS configuration. Please review it |
Minor comments LGTM |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/Azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@mlok-nokia, can you divide this PR in two, one for the config_db related change and one for the platform related change |
|
/Azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: mlok <[email protected]>
Signed-off-by: mlok <[email protected]>
…the code change Signed-off-by: mlok <[email protected]>
Signed-off-by: mlok <[email protected]>
Thanks. Done. |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
f068317
to
9e54124
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@judyjoseph @arlakshm and @xwjiang-ms VS test failure have been fixed. Please review it again. Thanks. |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
For any platform which supports the asic_sensors pulling, it requires the configuration files (config_db#.json) contain the following configuration to trigger the system to poll the ASIC sensors temperature. Fixes https://github.com/Nokia-ION/ndk/issues/48
Adding Yang model support to fixes #20633
Work item tracking
How I did it
Notice: For all platforms which support the asic_sensors polling requires to add the following definition to the device data platform.json file
Also add Yang Model support the ASIC_SENSORS configuration. INcluding YangModel UT.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)